package microvm import ( "encoding/json" "os" "path/filepath" "strings" "testing" ) func writeSpecFile(t *testing.T, path string) { t.Helper() data, err := json.Marshal(validImageSpec()) if err != nil { t.Fatal(err) } if err := os.MkdirAll(filepath.Dir(path), 0o755); err != nil { t.Fatal(err) } if err := os.WriteFile(path, data, 0o644); err != nil { t.Fatal(err) } } func TestResolveImageConventionalLayouts(t *testing.T) { cases := []struct { name string layout func(t *testing.T, dir string) }{ { name: "directory with spec.json", layout: func(t *testing.T, dir string) { writeSpecFile(t, filepath.Join(dir, "nixos", "spec.json")) }, }, { name: "flat .json", layout: func(t *testing.T, dir string) { writeSpecFile(t, filepath.Join(dir, "nixos.json")) }, }, } for _, tc := range cases { t.Run(tc.name, func(t *testing.T) { dir := t.TempDir() tc.layout(t, dir) e := testEngine(t, dir) spec, path, name, err := e.resolveImage("nixos") if err != nil { t.Fatalf("resolveImage: %v", err) } if name != "nixos" { t.Fatalf("name = %q, want nixos", name) } if !strings.HasPrefix(path, dir) { t.Fatalf("resolved path %q not under image dir %q", path, dir) } if spec.Shell == "" { t.Fatal("resolved spec not loaded") } }) } } func TestResolveImageDirectoryMissingSpec(t *testing.T) { dir := t.TempDir() if err := os.MkdirAll(filepath.Join(dir, "nixos"), 0o755); err != nil { t.Fatal(err) } e := testEngine(t, dir) _, _, _, err := e.resolveImage("nixos") if err == nil || !strings.Contains(err.Error(), imageSpecFileName) { t.Fatalf("directory without %s should error, got: %v", imageSpecFileName, err) } } func TestResolveImageRequiresImageDirOnlyWhenUsed(t *testing.T) { e := testEngine(t, "") _, _, _, err := e.resolveImage("nixos") if err == nil || !strings.Contains(err.Error(), "SPINDLE_MICROVM_PIPELINES_IMAGE_DIR") { t.Fatalf("missing image directory should error when resolving an image, got: %v", err) } } func TestResolveImageRejectsPaths(t *testing.T) { e := testEngine(t, t.TempDir()) for _, name := range []string{"/etc/passwd", "../evil", "sub/evil", "..", "."} { if _, _, _, err := e.resolveImage(name); err == nil || !strings.Contains(err.Error(), "must be a plain name") { t.Fatalf("name %q should be rejected as a path, got: %v", name, err) } } } func validImageSpec() ImageSpec { return ImageSpec{ Arch: "x86_64", BootArgs: "console=ttyS0", Initrd: "initrd", Kernel: "kernel", RunnerConfig: RunnerConfig{ Machine: "microvm", }, MemoryMiB: 2048, Shell: "/bin/sh", StoreDisk: "store-disk", VCPUs: 2, } } func TestImageSpecValidateWithoutBaseConfigHash(t *testing.T) { spec := validImageSpec() if err := spec.Validate(); err != nil { t.Fatalf("non-NixOS image spec should validate: %v", err) } if spec.SupportsConfigActivation() { t.Fatal("spec without baseConfigHash should not support config activation") } spec.BaseConfigHash = "abcdef" if !spec.SupportsConfigActivation() { t.Fatal("spec with baseConfigHash should support config activation") } } func TestImageSpecRequiresShell(t *testing.T) { spec := validImageSpec() spec.Shell = "" err := spec.Validate() if err == nil || !strings.Contains(err.Error(), "shell") { t.Fatalf("spec without shell should fail validation, got: %v", err) } }