Commits
Signed-off-by: noriaki watanabe <nabeyang@gmail.com>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Signed-off-by: dawn <dawn@tangled.org>
Signed-off-by: Will <did:plc:dadhhalkfcq3gucaq25hjqon>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Signed-off-by: tinybuttercom <184706546+tinybuttercom@users.noreply.github.com>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Signed-off-by: dawn <dawn@tangled.org>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Signed-off-by: dawn <dawn@tangled.org>
Signed-off-by: dawn <dawn@tangled.org>
Signed-off-by: dawn <dawn@tangled.org>
Signed-off-by: dawn <dawn@tangled.org>
Signed-off-by: dawn <dawn@tangled.org>
Signed-off-by: dawn <dawn@tangled.org>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Signed-off-by: Wilhelm Berggren <wilhelmberggren@gmail.com>
Signed-off-by: Seongmin Lee <git@boltless.me>
Signed-off-by: Wilhelm Berggren <wilhelmberggren@gmail.com>
Signed-off-by: Seongmin Lee <git@boltless.me>
Signed-off-by: Wilhelm Berggren <wilhelmberggren@gmail.com>
Signed-off-by: Seongmin Lee <git@boltless.me>
Signed-off-by: Wilhelm Berggren <wilhelmberggren@gmail.com>
Signed-off-by: Seongmin Lee <git@boltless.me>
Ideally both `body` and `blobs` should be wrapped as single `body` field
with `sh.tangled.markup.markdown` type like `sh.tangled.feed.comment`
records, but that breaking change is deferred for later `org.tangled.*`
migration.
Signed-off-by: Wilhelm Berggren <wilhelmberggren@gmail.com>
Signed-off-by: Seongmin Lee <git@boltless.me>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
`if` effectively neuters `set -e`:
```
$ bash -c 'set -ex; f() { false; echo 123; }; if f; then echo 456; fi'
+ f
+ false
+ echo 123
123
+ echo 456
456
```
so the test keeps on running. Instead, we can rely on `exit` (which is
not going to break as easily) + a subshell to make sure we actually
catch error codes. (This might also cause other forms of test "failure"
to not get detected, as well.)
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Signed-off-by: Anirudh Oppiliappan <anirudh@tangled.org>
Signed-off-by: Anirudh Oppiliappan <anirudh@tangled.org>
Signed-off-by: Anirudh Oppiliappan <anirudh@tangled.org>
it fails on file:// clone
Signed-off-by: Seongmin Lee <git@boltless.me>
Signed-off-by: dawn <dawn@tangled.org>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Signed-off-by: Trey Bastian <hello@treybastian.com>
fixed reversing the env var names
Signed-off-by: Trey Bastian <hello@treybastian.com>
Signed-off-by: dawn <dawn@tangled.org>
Lewis: May this revision serve well! <did:plc:3fwecdnvtcscjnrx2p4n7alz>
Signed-off-by: Seongmin Lee <git@boltless.me>
Signed-off-by: Seongmin Lee <git@boltless.me>
Signed-off-by: dawn <dawn@tangled.org>
Signed-off-by: dawn <dawn@tangled.org>
Signed-off-by: Seongmin Lee <git@boltless.me>
Signed-off-by: dawn <dawn@tangled.org>
Signed-off-by: Anirudh Oppiliappan <anirudh@tangled.org>
Signed-off-by: dawn <dawn@tangled.org>
initCgroupParent skips the parent-process move at group "/", assuming
the real root cgroup, which is exempt from the no-internal-process
constraint. in a private cgroup namespace (podman and docker's default
on cgroup v2) "/" is a populated delegated NON-root cgroup instead, so
the first workflow fails: 'failed to write subtree controllers
[memory pids] to "/sys/fs/cgroup/cgroup.subtree_control"': EBUSY.
userspace cannot tell the two "/"s apart — cgroup namespaces
virtualize /proc/self/cgroup and mountinfo for the reader — but the
constraint can: it exempts only the real root. probe it by writing
+memory +pids to cgroup.subtree_control: succeeds at the real root
(the same write prepareCgroup does per microVM anyway), EBUSY at a
populated namespace root, where we then vacate exactly as on the
group != "/" path. a read-only cgroupfs now fails loudly at init
instead of mid-workflow.
verified in scratch podman containers: unpatched reproduces the EBUSY,
patched passes the new regression test and enforces memory.max.
Signed-off-by: Winter <winter@madoka.systems>
Signed-off-by: noriaki watanabe <nabeyang@gmail.com>
Signed-off-by: Seongmin Lee <git@boltless.me>
This still marks the unshown ones as "emailed" so we don't send them in
the next digest tick.
Signed-off-by: Anirudh Oppiliappan <anirudh@tangled.org>
Ideally both `body` and `blobs` should be wrapped as single `body` field
with `sh.tangled.markup.markdown` type like `sh.tangled.feed.comment`
records, but that breaking change is deferred for later `org.tangled.*`
migration.
Signed-off-by: Wilhelm Berggren <wilhelmberggren@gmail.com>
Signed-off-by: Seongmin Lee <git@boltless.me>
`if` effectively neuters `set -e`:
```
$ bash -c 'set -ex; f() { false; echo 123; }; if f; then echo 456; fi'
+ f
+ false
+ echo 123
123
+ echo 456
456
```
so the test keeps on running. Instead, we can rely on `exit` (which is
not going to break as easily) + a subshell to make sure we actually
catch error codes. (This might also cause other forms of test "failure"
to not get detected, as well.)
initCgroupParent skips the parent-process move at group "/", assuming
the real root cgroup, which is exempt from the no-internal-process
constraint. in a private cgroup namespace (podman and docker's default
on cgroup v2) "/" is a populated delegated NON-root cgroup instead, so
the first workflow fails: 'failed to write subtree controllers
[memory pids] to "/sys/fs/cgroup/cgroup.subtree_control"': EBUSY.
userspace cannot tell the two "/"s apart — cgroup namespaces
virtualize /proc/self/cgroup and mountinfo for the reader — but the
constraint can: it exempts only the real root. probe it by writing
+memory +pids to cgroup.subtree_control: succeeds at the real root
(the same write prepareCgroup does per microVM anyway), EBUSY at a
populated namespace root, where we then vacate exactly as on the
group != "/" path. a read-only cgroupfs now fails loudly at init
instead of mid-workflow.
verified in scratch podman containers: unpatched reproduces the EBUSY,
patched passes the new regression test and enforces memory.max.
Signed-off-by: Winter <winter@madoka.systems>